Skip to content

Commit 69ad705

Browse files
gmackallGray Mackallreidbaker
authored andcommitted
Add docs for setting up Android Studio to auto format Kotlin code (flutter#159209)
Docs to make Android Studio auto format kotlin code in a way compatible with the format check that we make in CI. Open to suggestions as to a better place to put them, but there wasn't an existing doc that seemed like an obvious fit to me. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <[email protected]> Co-authored-by: Reid Baker <[email protected]>
1 parent 00cb622 commit 69ad705

File tree

2 files changed

+29
-1
lines changed

2 files changed

+29
-1
lines changed

dev/bots/analyze.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2126,7 +2126,8 @@ Future<void> lintKotlinFiles(String workingDirectory) async {
21262126
'To reproduce this lint locally:\n'
21272127
'1. Identify the CIPD version tag used to resolve this particular version of ktlint (check the dependencies section of this shard in the ci.yaml). \n'
21282128
'2. Download that version from https://chrome-infra-packages.appspot.com/p/flutter/ktlint/linux-amd64/+/<version_tag>\n'
2129-
'3. From the repository root, run `<path_to_ktlint>/ktlint --editorconfig=$editorConfigRelativePath --baseline=$baselineRelativePath`';
2129+
'3. From the repository root, run `<path_to_ktlint>/ktlint --editorconfig=$editorConfigRelativePath --baseline=$baselineRelativePath`\n'
2130+
'Alternatively, if you use Android Studio, follow the docs at docs/platforms/android/Kotlin-android-studio-formatting.md to enable auto formatting.';
21302131
foundError(<String>[errorMessage]);
21312132
}
21322133
}
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Setting up Kotlin formatting in Android Studio
2+
3+
Kotlin code in this repository is formatted and linted with [`ktlint`](https://github.com/pinterest/ktlint).
4+
If you
5+
1. have submitted Kotlin code only to learn this when the analyzer check fails
6+
2. use Android Studio
7+
8+
9+
then there is good news! Android Studio can be configured to use `ktlint` to automatically apply formatting and highlight issues. To do this:
10+
11+
12+
1. Install the `ktlint` extension for Android Studio
13+
14+
a. On Mac, this is `Android Studio > Settings > Plugins > ` Search for `ktlint`.
15+
16+
2. Set the ruleset to be the same as the version used in [`.ci.yaml`](../../../.ci.yaml) (as of writing this is 1.1.1), and the baseline to be `dev/bots/test/analyze-test-input/ktlint-baseline.xml`.
17+
18+
a. Both of these options should be available under `Android Studio > Settings > Tools > ktlint`.
19+
20+
3. Additionally, Kotlin code in the Flutter repository currently uses some additional rules for compatibility with older versions of Kotlin.
21+
These rules can only be configured by an `.editorconfig` file in the directory from which Android Studio was opened. To configure these rules, create a new `.editorconfig` file in the root of your flutter repository with the following content
22+
```
23+
[*.{kt,kts}]
24+
# Disable trailing commas to allow compatibility with Kotlin versions less than 1.4.
25+
ij_kotlin_allow_trailing_comma = false
26+
ij_kotlin_allow_trailing_comma_on_call_site = false
27+
```

0 commit comments

Comments
 (0)