SDK changes to make use of 'V2' ontologies APIs, plus 'include_org_access' feature #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2024 17:34
Unit test report ((Pydantic 2.x)180 tests 180 ✅ 4s ⏱️ Results for commit ca843d7. |
Unit test report (Pydantic 1.x)180 tests 180 ✅ 4s ⏱️ Results for commit ca843d7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction and Explanation
Adding 'list all the ontologies in the org' feature, and converting the whole feature to use the '/v2' SDK. Based/depends on https://github.com/encord-team/cord-backend/pull/4349
Documentation
The functional change is just a single parameter that's documented in the source. Will need user-facing 'story' type documentation, but probably only once the whole suite of 'org-wide access' features will land (projects/datasets/folders, at least).
Tests
Mostly covered by the existing SDK testsuite; plus the specific test is coming with the BE change.
Known issues
Relying on very old crufty objects to pass data around -- but these are semi-public so don't want to break the clients.