Merged
Conversation
Kludex
requested review from
abersheeran,
adriangb,
alex-oleshkevich and
florimondmanca
alex-oleshkevich
approved these changes
Nov 27, 2023
Contributor
|
That's a good PR! |
Contributor
|
Looks great to me! |
Owner
Author
|
I'll wait a couple of days to see if @florimondmanca or @tomchristie wants to say something here. |
Kludex
changed the title
Router/WebSocketRoute
Kludex
changed the title
Router/WebSocketRouteRoute/WebSocketRoute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tom expressed his opinion about this on #1286 (comment).
This will prevent the need of #2175, since we can add a middleware that limits the request body on the
Routewith it.Related issues
Does it solve Include routing information for middleware #685?No.