Don't use 'raise exc from None' because it suppresses exception causes#1158
Merged
lovelydinosaur merged 1 commit intoKludex:masterfrom Mar 29, 2021
oTree-org:master
Merged
Don't use 'raise exc from None' because it suppresses exception causes#1158lovelydinosaur merged 1 commit intoKludex:masterfrom oTree-org:master
lovelydinosaur merged 1 commit intoKludex:masterfrom
oTree-org:master
Conversation
lovelydinosaur
approved these changes
Mar 29, 2021
Contributor
lovelydinosaur
left a comment
lovelydinosaur
left a comment
There was a problem hiding this comment.
All of these cases look more correct to me without the "from None" yup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1114
I think
raise exc from Noneis better for targeted cases (like catching KeyError to re-raise a more suitable exception). For catch-all clauses likeexcept Exceptionwe are potentially throwing out useful info about the cause.