Removed requirements txt files from project. #9842

p-r-a-v-i-n · 2025-12-07T13:56:16Z

we have migrated to pyproject.toml so now I think it is safe to remove requirements folder and requirements.txt file bcs pyproject.toml could take care of those installations. I have shifted those all dependencies in pyproject.toml.

Copilot

Pull request overview

This PR migrates dependency management from multiple requirements/*.txt files to a centralized pyproject.toml configuration, organizing dependencies into optional dependency groups (testing, optional, documentation, packaging). This modernizes the project's dependency management approach using PEP 621 standards.

Key Changes

Migrated all dependencies from 5 requirements files into pyproject.toml optional-dependencies groups
Updated tox.ini to use pyproject.toml optional dependencies instead of requirements files
Updated installation instructions in documentation and CI workflows

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 20 comments.

Show a summary per file

File	Description
pyproject.toml	Added four optional-dependencies groups (documentation, optional, packaging, testing) with migrated dependencies
tox.ini	Updated all test environments to install dependencies using `.[group]` syntax instead of `-r requirements/*.txt`
docs/community/contributing.md	Updated installation instructions to use pyproject.toml optional dependencies
.github/workflows/main.yml	Updated CI workflow to install dependencies from pyproject.toml
requirements.txt	Removed root requirements file
requirements/requirements-*.txt	Removed all requirements directory files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-07T15:08:57Z

pyproject.toml

+  "twine>=3.4.2,<4.0.2",
+
+  # Wheel for PyPI installs.
+  "wheel>=0.36.2,<0.40",


The version specification has been changed from wheel>=0.36.2,<0.40.0 (in requirements-packaging.txt) to wheel>=0.36.2,<0.40. The trailing .0 should be preserved to match the original upper bound. Change to "wheel>=0.36.2,<0.40.0".

Suggested change

"wheel>=0.36.2,<0.40",

"wheel>=0.36.2,<0.40.0",

pyproject.toml

Copilot · 2025-12-07T15:08:58Z

tox.ini

-        django<6.1
-        -rrequirements/requirements-testing.txt
-        -rrequirements/requirements-optionals.txt
+       .[testing, optional]


Inconsistent indentation: this line uses 7 spaces while line 25 uses 8 spaces. The indentation should be consistent across all deps entries. Use the same indentation as line 25.

Suggested change

.[testing, optional]

.[testing, optional]

pyproject.toml

Copilot · 2025-12-07T15:09:02Z

tox.ini

 deps =
-       -rrequirements/requirements-testing.txt
-       -rrequirements/requirements-documentation.txt
+      .[testing, documentation]


The syntax for specifying multiple optional dependencies should use a comma without space: .[testing,documentation] instead of .[testing, documentation]. The space after the comma may cause issues with some pip versions.

Suggested change

.[testing, documentation]

.[testing,documentation]

Copilot · 2025-12-07T15:09:02Z

tox.ini

+

Unnecessary trailing whitespace on this line. Remove the trailing spaces.

Suggested change

Copilot · 2025-12-07T15:09:03Z

.github/workflows/main.yml


    - name: Install dependencies
-      run: pip install -r requirements/requirements-documentation.txt
+      run: pip install -e .[testing]


Incorrect optional dependencies specified. This workflow step should install documentation dependencies to run mkdocs, not testing dependencies. Change to pip install -e .[documentation] to match the original requirements-documentation.txt installation.

Suggested change

run: pip install -e .[testing]

run: pip install -e .[documentation]

Copilot · 2025-12-07T15:09:03Z

tox.ini

        djangomain: https://github.com/django/django/archive/main.tar.gz
-        -rrequirements/requirements-testing.txt
-        -rrequirements/requirements-optionals.txt
+        .[testing, optional]


The syntax for specifying multiple optional dependencies should use a comma without space: .[testing,optional] instead of .[testing, optional]. The space after the comma may cause issues with some pip versions.

docs/community/contributing.md

browniebroke

Using optional-dependencies for that is IMO the wrong way to solve this.

pyproject.toml

browniebroke

Nearly there

browniebroke · 2025-12-08T08:15:34Z

tox.ini

 [testenv]
-commands = python -W error::DeprecationWarning -W error::PendingDeprecationWarning runtests.py --coverage {posargs}
+commands =
+       pip install --group test --group optional


Tox supports dependency-groups natively too: https://tox.wiki/en/stable/config.html#dependency_groups

You can specify them like we specify deps:

dependency_groups = test optional

(I would put this just before the existing deps)

wow thanks again Bruno, How do you do this everytime ? I'm really curious literally almost 2 to 3 times i went through https://tox.wiki/en/stable/config.html, trust me i remember i saw dependency_groups but i didn't understand what it was doing .

Yes, tox is quite powerful and supports a ton of options, and it sometimes tricky to find the right knob in the documentation. This one is quite recent I imagine as PEP 735 is fairly new.

…n.yml

browniebroke · 2025-12-08T18:33:14Z

I think there is still a mention here:

django-rest-framework/docs/community/project-management.md

Lines 84 to 88 in c847be5

    
           ## Project requirements 
        
           All our test requirements are pinned to exact versions, in order to ensure that our test runs are reproducible. We maintain the requirements in the `requirements` directory. The requirements files are referenced from the `tox.ini` configuration file, ensuring we have a single source of truth for package versions used in testing. 
        
           Package upgrades should generally be treated as isolated pull requests. You can check if there are any packages available at a newer version, by using the `pip list --outdated`.

This one should be removed:

django-rest-framework/.github/workflows/main.yml

Line 31 in b05db8b

cache-dependency-path: 'requirements/*.txt'

And this one should be changed to pyproject.toml:

django-rest-framework/.github/workflows/mkdocs-deploy.yml

Line 10 in 1c4af77

- requirements/requirements-documentation.txt

Also this:

django-rest-framework/.github/workflows/mkdocs-deploy.yml

Line 28 in 1c4af77

- run: pip install -r requirements/requirements-documentation.txt

* Removed references to `requirements.txt` in GitHub Actions workflows. * Updated `mkdocs-deploy.yml` and `main.yml` to install dependencies using `pyproject.toml`. * Cleaned up documentation to remove mentions of the `requirements` folder.

p-r-a-v-i-n · 2025-12-09T03:56:27Z

I think there is still a mention here:

django-rest-framework/docs/community/project-management.md

Lines 84 to 88 in c847be5

## Project requirements

All our test requirements are pinned to exact versions, in order to ensure that our test runs are reproducible. We maintain the requirements in the `requirements` directory. The requirements files are referenced from the `tox.ini` configuration file, ensuring we have a single source of truth for package versions used in testing.

Package upgrades should generally be treated as isolated pull requests. You can check if there are any packages available at a newer version, by using the `pip list --outdated`.

This one should be removed:

django-rest-framework/.github/workflows/main.yml

Line 31 in b05db8b

cache-dependency-path: 'requirements/*.txt'

And this one should be changed to pyproject.toml:

django-rest-framework/.github/workflows/mkdocs-deploy.yml

Line 10 in 1c4af77

- requirements/requirements-documentation.txt

Also this:

django-rest-framework/.github/workflows/mkdocs-deploy.yml

Line 28 in 1c4af77

- run: pip install -r requirements/requirements-documentation.txt

Thanks for catching this.

p-r-a-v-i-n marked this pull request as draft December 7, 2025 13:56

p-r-a-v-i-n marked this pull request as ready for review December 7, 2025 14:10

auvipy requested review from auvipy and Copilot December 7, 2025 15:03

Copilot started reviewing on behalf of auvipy December 7, 2025 15:04 View session

Copilot AI reviewed Dec 7, 2025

View reviewed changes

p-r-a-v-i-n force-pushed the remove-requirements branch 2 times, most recently from 0699662 to 54a17b2 Compare December 7, 2025 15:37

browniebroke reviewed Dec 7, 2025

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

p-r-a-v-i-n force-pushed the remove-requirements branch 2 times, most recently from c87972b to 2f2086d Compare December 8, 2025 06:09

p-r-a-v-i-n requested a review from browniebroke December 8, 2025 06:24

browniebroke reviewed Dec 8, 2025

View reviewed changes

p-r-a-v-i-n added 5 commits December 8, 2025 15:51

removed requirements txt files

f3757ed

Updated Testing section from Contributing.md

58d82d6

updated command to install dependencies for documentation in CI

fff5e24

updated tox.ini

b883295

build: Adopt PEP 735 for development dependency management

1c989df

p-r-a-v-i-n force-pushed the remove-requirements branch from 2f2086d to e5a1a57 Compare December 8, 2025 10:21

p-r-a-v-i-n requested a review from browniebroke December 8, 2025 10:23

p-r-a-v-i-n force-pushed the remove-requirements branch from e5a1a57 to 70b7949 Compare December 8, 2025 10:53

p-r-a-v-i-n added 2 commits December 8, 2025 16:27

Update installation commands for dependency groups in tox.ini and mai…

b05db8b

…n.yml

update installation command in testing section of contributing docs

c847be5

p-r-a-v-i-n force-pushed the remove-requirements branch from 70b7949 to c847be5 Compare December 8, 2025 10:58

	run: pip install -e .[testing]
	run: pip install -e .[documentation]

Uh oh!

Removed requirements txt files from project. #9842

Are you sure you want to change the base?

Removed requirements txt files from project. #9842

Conversation

p-r-a-v-i-n commented Dec 7, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

browniebroke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

browniebroke left a comment

Choose a reason for hiding this comment

Uh oh!

browniebroke Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

p-r-a-v-i-n Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

browniebroke Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

browniebroke commented Dec 8, 2025

Uh oh!

p-r-a-v-i-n commented Dec 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants