Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode correctness #36

Open
maiself opened this issue Dec 22, 2022 · 0 comments
Open

Unicode correctness #36

maiself opened this issue Dec 22, 2022 · 0 comments

Comments

@maiself
Copy link
Contributor

maiself commented Dec 22, 2022

There are still some Unicode conversion problems in the adapter. Most should be easy to fix (std::string -> std::wstring), but they need to be located. Tracking them here may be helpful. Tests to ensure things continue to behave correctly would also be good.

There is a particular issue with writing unicode characters to sys.stdout / sys.stderr. Normally these are initialized as having a utf-8 encoding, but in pyjs they are initialized as ascii. This seems to be a result of how pybind11 initializes the scoped interpreter. I'm not sure which project should fix this or what the best way to do so is.

There may also be other yet to be discovered unicode issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant