From 08680fc6dbccb5f4fb50e69c9921629509176486 Mon Sep 17 00:00:00 2001
From: Sam Clegg <sbc@chromium.org>
Date: Mon, 20 Oct 2025 16:11:06 -0700
Subject: [PATCH] Cleanup test_emscripten_api

- Parameterize the test
- Remove unnecessary skipping under sanitizers
---
 test/test_core.py | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/test/test_core.py b/test/test_core.py
index 93b7f35e7c24a..0356186905712 100644
--- a/test/test_core.py
+++ b/test/test_core.py
@@ -1855,18 +1855,15 @@ def test_set_align(self):
 
   @no_modularize_instance('uses Module object directly')
   @no_js_math('JS_MATH is not compatible with LINKABLE')
-  def test_emscripten_api(self):
-    self.set_setting('EXPORTED_FUNCTIONS', ['_main', '_save_me_aimee'])
-    self.do_core_test('test_emscripten_api.c')
-
-    # Sanitizers are not compatible with LINKABLE (dynamic linking).
-    # LLVM-libc overlay mode is not compatible with whole-archive (LINKABLE)
-    if not is_sanitizing(self.cflags) and not self.is_wasm64() and '-lllvmlibc' not in self.cflags:
-      # test EXPORT_ALL
-      self.clear_setting('EXPORTED_FUNCTIONS')
-      self.set_setting('EXPORT_ALL')
-      self.set_setting('LINKABLE')
-      self.do_core_test('test_emscripten_api.c', cflags=['-Wno-deprecated'])
+  @parameterized({
+    '': (['-sEXPORTED_FUNCTIONS=_main,_save_me_aimee'],),
+    # test EXPORT_ALL too
+    'export_all': (['-Wno-deprecated', '-sEXPORT_ALL', '-sLINKABLE'],),
+  })
+  def test_emscripten_api(self, args):
+    if '-sLINKABLE' in args and '-lllvmlibc' in self.cflags:
+      self.skipTest('LLVM-libc overlay mode is not compatible with whole-archive (LINKABLE)')
+    self.do_core_test('test_emscripten_api.c', cflags=args)
 
   def test_emscripten_run_script_string_int(self):
     src = r'''