Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make intArrayToString symmetric to intArrayFromString #5442

Closed
juj opened this issue Aug 8, 2017 · 1 comment
Closed

Make intArrayToString symmetric to intArrayFromString #5442

juj opened this issue Aug 8, 2017 · 1 comment
Labels

Comments

@juj
Copy link
Collaborator

juj commented Aug 8, 2017

We probably would want the following two invariants to hold for all valid inputs:

intArrayToString(intArrayFromString(someStringContainingNonBasicMultilingualPlaneUnicodeCharacters)) == someStringContainingNonBasicMultilingualPlaneUnicodeCharacters
intArrayFromString(intArrayToString(someArrayContainingAValidUTF8EncodedString)) == someArrayContainingAValidUTF8EncodedString

Currently reading the implementation of intArrayToString(), this is not the case. The implementation of intArrayFromString() looks good.

Currently the PR #5296 is touching this area, so should tend to this only after that PR lands.

@stale
Copy link

stale bot commented Aug 30, 2019

This issue has been automatically marked as stale because there has been no activity in the past 2 years. It will be closed automatically if no further activity occurs in the next 7 days. Feel free to re-open at any time if this issue is still relevant.

@stale stale bot added the wontfix label Aug 30, 2019
@stale stale bot closed this as completed Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant