From f997bf0f0ea38e1b115b66032dde5ba942157f58 Mon Sep 17 00:00:00 2001 From: Peter Kong Date: Wed, 29 Nov 2023 13:02:01 -0500 Subject: [PATCH] delete unused webpacker-dependent specfile; linting --- .../containers/PremiumHubContainer.jsx | 1 + .../system/activity_pack_assignment_spec.rb | 87 ------------------- 2 files changed, 1 insertion(+), 87 deletions(-) delete mode 100644 services/QuillLMS/spec/system/activity_pack_assignment_spec.rb diff --git a/services/QuillLMS/client/app/bundles/PremiumHub/containers/PremiumHubContainer.jsx b/services/QuillLMS/client/app/bundles/PremiumHub/containers/PremiumHubContainer.jsx index 03c01877ac5..dddf4d231ab 100644 --- a/services/QuillLMS/client/app/bundles/PremiumHub/containers/PremiumHubContainer.jsx +++ b/services/QuillLMS/client/app/bundles/PremiumHub/containers/PremiumHubContainer.jsx @@ -6,6 +6,7 @@ import DistrictConceptReportsProgressReport from './DistrictConceptReports'; import DistrictStandardsReportsProgressReport from './DistrictStandardsReports'; import IntegrationsContainer from './IntegrationsContainer'; import PremiumFilterableReportsContainer from './PremiumFilterableReportsContainer'; +import PremiumHub from './PremiumHub'; import SchoolSubscriptionsContainer from './SchoolSubscriptionsContainer'; import { requestGet, } from '../../../modules/request/index'; diff --git a/services/QuillLMS/spec/system/activity_pack_assignment_spec.rb b/services/QuillLMS/spec/system/activity_pack_assignment_spec.rb deleted file mode 100644 index 739e88f60a3..00000000000 --- a/services/QuillLMS/spec/system/activity_pack_assignment_spec.rb +++ /dev/null @@ -1,87 +0,0 @@ -# frozen_string_literal: true - -require 'rails_helper' - -RSpec.describe 'Activity Pack Assignment' do - include AuthenticationHelper - - let!(:teacher) { create(:teacher_with_a_couple_classrooms_with_one_student_each) } - let!(:student) { teacher.students.first } - let!(:classroom) { student.classrooms.first } - - let!(:activity_landing_page_instructions) { 'You’re about to answer 1 questions on writing sentences.' } - let!(:activity_landing_page_html) do - <<-HTML -

Baseline Diagnostic

-

#{activity_landing_page_instructions}

-

-
- Some of the questions might be about things you haven’t learned yet—that’s okay! - Just answer them as best as you can. Don’t forget to read the instructions carefully for each question! -

-

-
- Once you’re finished, Quill will create a learning plan just for you. -

- HTML - end - - let!(:activity_data) do - { - "flag" => "archived", - "name" => activity_name, - "questions" => [{"key"=>question_uid, "questionType"=> "fillInBlank"}], - "landingPageHtml"=> activity_landing_page_html - } - end - let!(:activity_name) { 'Starter Baseline Diagnostic (Pre)' } - let!(:activity) { create(:diagnostic_activity, id: Activity::STARTER_DIAGNOSTIC_ACTIVITY_ID, data: activity_data) } - - let!(:question_uid) { 'CIxOvSep_iXq1pzQ5QnENA' } - let!(:question_type) { Question::TYPE_DIAGNOSTIC_FILL_IN_BLANKS } - let!(:question_data) do - { - "cues"=>["don't", "doesn't"], - "flag"=> "archived", - "prompt"=>"He ___ like to wake up early.", - "conceptID"=> nil, - "cuesLabel"=>"action words", - "blankAllowed"=>false, - "instructions"=> question_instructions, - "caseInsensitive"=>true - } - end - let!(:question_instructions) { 'Fill in the blank with the action word that matches the rest of the sentence.' } - let!(:question) { create(:question, uid: question_uid, question_type: question_type, data: question_data) } - - let!(:unit_template) { create(:unit_template, id: 99, name: activity_name) } - - before { student.update(password: 'password') } - - xit 'teachers can assign an activity packs to their students', :js, retry: 3 do - login_user(teacher.email, teacher.password) - click_button "Let's go!" - find('li#student-reports-link', text: 'My Reports').click - find('a.diagnostic-tab', text: 'Diagnostics').click - click_on 'Assign a diagnostic' - first(:button, 'Select').click - find('span.all-classes-text', text: 'All classes and students').sibling('span').click - # the following line checks for the presence of an element that only loads once activity data has loaded, ensuring that the assign click will be successful - first('.review-activities-data-table-section').click - click_on 'Assign pack to classes' - - # TODO: Fix bug in which you can click too fast and break this flow (remove sleep when that is done) - sleep 2 - click_on 'Next' - click_on 'Take me to my dashboard' - logout_user(teacher) - - login_user(student.username, student.password) - click_on classroom.name - click_on 'Start' - expect(page).to have_content activity_landing_page_instructions - click_on 'Begin' - expect(page).to have_content question_instructions - click_on 'Save and exit' - end -end