Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer lags while closing with swipe, when there is a more content on the page #475

Open
afkcodes opened this issue Oct 6, 2024 · 8 comments

Comments

@afkcodes
Copy link

afkcodes commented Oct 6, 2024

There is good amount of content on the page, the drawer opens fine it open smoothly but while closing it lags,
Note: All the interactions are swipe

Screen.Recording.2024-10-06.at.8.40.42.PM.mov
@emilkowalski
Copy link
Owner

Can you provide a demo with reproduction?

@afkcodes
Copy link
Author

sure will create a demo

@PlagueFPS
Copy link

Yes, I am experiencing this as well, only on close.

@afkcodes
Copy link
Author

afkcodes commented Oct 13, 2024

here is the reproducible: https://github.com/afkcodes/sunoh-pwa/ this is the project and
demo: https://sunoh-virid.vercel.app check it on mobile @emilkowalski

@T-Damer
Copy link

T-Damer commented Oct 26, 2024

Same for me, swipe to close is laggy on iOS and Android (touch devices, I guess), but works fine on mouse-input devices
I am not sure if it's connected to the amount of elements on the page or inside the modal

@T-Damer
Copy link

T-Damer commented Oct 26, 2024

2024-10-26.19.01.00.mp4

Here's the demo with simple modal, it uses the Root, Portal, Overlay, Content, Handle, Close elements
Content is fixed bottom-0 left-0 right-0

@T-Damer
Copy link

T-Damer commented Oct 26, 2024

I recorder DOM mutatitions, looks like tranlate3d updates to higher position on second frame

1 2 3 4
CleanShot 2024-10-26 at 19 05 25@2x CleanShot 2024-10-26 at 19 06 26@2x CleanShot 2024-10-26 at 19 06 36 2@2x CleanShot 2024-10-26 at 19 06 58@2x

@T-Damer
Copy link

T-Damer commented Oct 26, 2024

Removing snapPoints fixes the issue, so I guess it's something about snapping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants