Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker is not standard #2681

Closed
oredaze opened this issue Feb 5, 2023 · 6 comments · Fixed by #2727
Closed

Color picker is not standard #2681

oredaze opened this issue Feb 5, 2023 · 6 comments · Fixed by #2727

Comments

@oredaze
Copy link

oredaze commented Feb 5, 2023

In most graphics software like Photoshop you will see the color picker be like the right side. When you flip the colors like this it gets confusing for me and probably for a lot of other people. Please consider changing it.
Also the color selection circle is very huge. I don't know about that...

picker

@robertpauson
Copy link

it opens right bottom and so on mobile it won't be accessible if the button is let's say also near the bottom.

parts of the widget are inaccessible and the picker can't be moved.

to fix that I had to modify repo with the line that defaults and kinda anchors it, so that it opened elsewhere and was movable

@oredaze
Copy link
Author

oredaze commented Feb 6, 2023

Perhaps I am misunderstanding what you are saying, or it's the other way around, but I am talking about the colors inside the picker, not it's position. Notice how the white corner is bottom-right, but the standard is top-left.

@Mingun
Copy link
Contributor

Mingun commented Feb 6, 2023

Not sure that this is the rule. Shutter uses egui layout:
Shutter color selection

@oredaze
Copy link
Author

oredaze commented Feb 6, 2023

It's not a rule of course, it's just the most common way of doing it. Things that use my suggestion include: Photoshop; Krita; plugins for the aforementioned; Blender; Procreate; Artstudio pro; Rebelle; Painttool Sai; Clip Studio Paint; google search color picker; etc...

@emilk
Copy link
Owner

emilk commented Feb 6, 2023

I'm for going with the majority here - should be an easy PR if anyone wants to tackle it!

@IVAN-MK7
Copy link
Contributor

Accomplished by swapping hsva's saturation and value in the color_slider_2d in my fork's hsva_color_slider_2d_orientation branch

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants