From 8cef6fc872b5684cbf968d8bc530c7307bedd5da Mon Sep 17 00:00:00 2001 From: zkldi Date: Sun, 23 Jun 2024 10:50:35 +0100 Subject: [PATCH] doc(emath): Add `top_left` as an alias for `left_top`, etc. (#4689) # What Adds `#[doc(alias = "top_left")]` as an alias for `left_top`, and so on for `right_top`, `right_bottom`, `left_bottom`. # Why Extremely minor doc-only change, but I keep going to type "top left" to look for the top left of a rectangle. I'm unsure whether this is just a british-english thing or an english-in-general thing, but `top left corner` is far more common than `left top corner`. These doc aliases don't conflict with anything, and mean that rust-analyzer will suggest the correct function when I search for the wrong thing. This improves ergonomics and discoverability in my opinion, even if not by much. --- crates/emath/src/rect.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/crates/emath/src/rect.rs b/crates/emath/src/rect.rs index 42a67cfb4fb..28ca2ec464d 100644 --- a/crates/emath/src/rect.rs +++ b/crates/emath/src/rect.rs @@ -565,6 +565,7 @@ impl Rect { } #[inline(always)] + #[doc(alias = "top_left")] pub fn left_top(&self) -> Pos2 { pos2(self.left(), self.top()) } @@ -575,6 +576,7 @@ impl Rect { } #[inline(always)] + #[doc(alias = "top_right")] pub fn right_top(&self) -> Pos2 { pos2(self.right(), self.top()) } @@ -590,6 +592,7 @@ impl Rect { } #[inline(always)] + #[doc(alias = "bottom_left")] pub fn left_bottom(&self) -> Pos2 { pos2(self.left(), self.bottom()) } @@ -600,6 +603,7 @@ impl Rect { } #[inline(always)] + #[doc(alias = "bottom_right")] pub fn right_bottom(&self) -> Pos2 { pos2(self.right(), self.bottom()) }