Server and client can have different CSeq sequence

[serfreeman1337]

Example valid call flow:

10.0.3.16 started from 2693 and 10.0.3.1 started from 111. This is okay.

A here is sipgo (10.0.3.1) fails to handle BYE request after sending re-invites:

The following check fails because the same CSeq counter is used when sending and receiving requests:

sipgo/dialog_server.go

Lines 393 to 395 in 2d0a819

	if req.CSeq().SeqNo < dt.lastCSeqNo.Load() {
	return ErrDialogInvalidCseq
	}

[emiago]

ok it should be based on origin then. Thanks for this extensive reporting. It really speeds stuff up.

TODO:

• validate BYE request based on origin cseq not internal counter.