Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strip ' and " from config #107

Open
yannick opened this issue Jan 11, 2019 · 4 comments · May be fixed by #411
Open

strip ' and " from config #107

yannick opened this issue Jan 11, 2019 · 4 comments · May be fixed by #411

Comments

@yannick
Copy link

yannick commented Jan 11, 2019

note sure if a bug, but took some trial and error to figure it out what was wrong:

when converting from command line to the config file i noticed that the parser fails if e.g. the color is surrounded by quotes.
--border-color='#03E7B055' -> border-color='#03E7B055'

(also white spaces at the end of the line cause a fail)
@emersion
Copy link
Owner

Hmm, I'm not a fan of doing this.

(also white spaces at the end of the line cause a fail)

What do you mean by "fail"? Will it print an error and refuse to load the config file?

@yannick
Copy link
Author

yannick commented Jan 15, 2019

whitespaces:
it refuses to load with:
[config:1] Failed to parse option 'text-color'
which i guess is a quite confusing message.

@emersion
Copy link
Owner

Stripping end-of-line whitespace seems sensible as we're trimming whitespace around = anyway.

Error messages could be improved by printing the whole line.

@vilhalmer
Copy link
Collaborator

Update: #177 hopefully improved this situation, but I'll leave this open until we do something about the whitespace.

@emersion emersion mentioned this issue Mar 10, 2020
Closed
@emersion emersion mentioned this issue Jun 9, 2020
Closed
@pranjalkole pranjalkole linked a pull request Jan 23, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config: ignore leading and trailing whitespace pranjalkole/mako
3 participants
@yannick @vilhalmer @emersion