Skip to content

Commit d9b6541

Browse files
committed
[pinpoint-apm#9932] Remove thrift dependency of Collector module
1 parent 888bb62 commit d9b6541

File tree

66 files changed

+68
-5676
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

66 files changed

+68
-5676
lines changed

collector/src/main/java/com/navercorp/pinpoint/collector/PinpointCollectorModule.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
"classpath:servlet-context-collector.xml",
2121

2222
"classpath:applicationContext-collector-grpc.xml",
23-
"classpath:applicationContext-collector-thrift.xml",
2423
"classpath:applicationContext-collector-hbase.xml",
2524
})
2625
@Import({

collector/src/main/java/com/navercorp/pinpoint/collector/cluster/ClusterPointRepository.java

+1-7
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import com.navercorp.pinpoint.collector.receiver.grpc.PinpointGrpcServer;
2020
import com.navercorp.pinpoint.common.server.cluster.ClusterKey;
2121
import com.navercorp.pinpoint.rpc.common.SocketStateCode;
22-
import com.navercorp.pinpoint.rpc.server.PinpointServer;
2322
import org.apache.logging.log4j.LogManager;
2423
import org.apache.logging.log4j.Logger;
2524

@@ -93,12 +92,7 @@ public Set<ClusterKey> getAvailableAgentKeyList() {
9392
final ClusterKey key = entry.getKey();
9493
final Set<T> clusterPointSet = entry.getValue();
9594
for (T clusterPoint : clusterPointSet) {
96-
if (clusterPoint instanceof ThriftAgentConnection) {
97-
PinpointServer pinpointServer = ((ThriftAgentConnection) clusterPoint).getPinpointServer();
98-
if (SocketStateCode.isRunDuplex(pinpointServer.getCurrentStateCode())) {
99-
availableAgentKeySet.add(key);
100-
}
101-
} else if (clusterPoint instanceof GrpcAgentConnection) {
95+
if (clusterPoint instanceof GrpcAgentConnection) {
10296
PinpointGrpcServer pinpointGrpcServer = ((GrpcAgentConnection) clusterPoint).getPinpointGrpcServer();
10397
if (SocketStateCode.isRunDuplex(pinpointGrpcServer.getState())) {
10498
availableAgentKeySet.add(key);

collector/src/main/java/com/navercorp/pinpoint/collector/cluster/ClusterPointStateChangedEventHandler.java

-84
This file was deleted.

collector/src/main/java/com/navercorp/pinpoint/collector/cluster/route/DefaultRouteHandler.java

+1-5
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import com.navercorp.pinpoint.collector.cluster.ClusterPoint;
2020
import com.navercorp.pinpoint.collector.cluster.ClusterPointLocator;
2121
import com.navercorp.pinpoint.collector.cluster.GrpcAgentConnection;
22-
import com.navercorp.pinpoint.collector.cluster.ThriftAgentConnection;
2322
import com.navercorp.pinpoint.collector.cluster.route.filter.RouteFilter;
2423
import com.navercorp.pinpoint.io.ResponseMessage;
2524
import com.navercorp.pinpoint.thrift.dto.command.TCommandTransferResponse;
@@ -87,10 +86,7 @@ private TCommandTransferResponse onRoute0(RequestEvent event) {
8786
}
8887

8988
CompletableFuture<ResponseMessage> future;
90-
if (clusterPoint instanceof ThriftAgentConnection) {
91-
ThriftAgentConnection thriftAgentConnection = (ThriftAgentConnection) clusterPoint;
92-
future = thriftAgentConnection.request(event.getDeliveryCommand().getPayload());
93-
} else if (clusterPoint instanceof GrpcAgentConnection) {
89+
if (clusterPoint instanceof GrpcAgentConnection) {
9490
GrpcAgentConnection grpcAgentConnection = (GrpcAgentConnection) clusterPoint;
9591
future = grpcAgentConnection.request(event.getRequestObject());
9692
} else {

collector/src/main/java/com/navercorp/pinpoint/collector/cluster/route/StreamRouteHandler.java

+1-17
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,10 @@
1919
import com.navercorp.pinpoint.collector.cluster.ClusterPoint;
2020
import com.navercorp.pinpoint.collector.cluster.ClusterPointLocator;
2121
import com.navercorp.pinpoint.collector.cluster.GrpcAgentConnection;
22-
import com.navercorp.pinpoint.collector.cluster.ThriftAgentConnection;
2322
import com.navercorp.pinpoint.collector.cluster.route.filter.RouteFilter;
2423
import com.navercorp.pinpoint.rpc.packet.stream.StreamClosePacket;
2524
import com.navercorp.pinpoint.rpc.packet.stream.StreamCode;
2625
import com.navercorp.pinpoint.rpc.packet.stream.StreamResponsePacket;
27-
import com.navercorp.pinpoint.rpc.server.PinpointServer;
2826
import com.navercorp.pinpoint.rpc.stream.ClientStreamChannel;
2927
import com.navercorp.pinpoint.rpc.stream.ClientStreamChannelEventHandler;
3028
import com.navercorp.pinpoint.rpc.stream.ServerStreamChannel;
@@ -109,16 +107,7 @@ private TCommandTransferResponse onRoute0(StreamEvent event) {
109107
}
110108

111109
try {
112-
if (clusterPoint instanceof ThriftAgentConnection) {
113-
StreamRouteManager routeManager = new StreamRouteManager(event);
114-
115-
ServerStreamChannel consumerStreamChannel = event.getStreamChannel();
116-
consumerStreamChannel.setAttributeIfAbsent(ATTACHMENT_KEY, routeManager);
117-
118-
ClientStreamChannel producerStreamChannel = createStreamChannel((ThriftAgentConnection) clusterPoint, event.getDeliveryCommand().getPayload(), routeManager);
119-
routeManager.setProducer(producerStreamChannel);
120-
return createResponse(TRouteResult.OK);
121-
} else if (clusterPoint instanceof GrpcAgentConnection) {
110+
if (clusterPoint instanceof GrpcAgentConnection) {
122111
StreamRouteManager routeManager = new StreamRouteManager(event);
123112

124113
ServerStreamChannel consumerStreamChannel = event.getStreamChannel();
@@ -142,11 +131,6 @@ private TCommandTransferResponse onRoute0(StreamEvent event) {
142131
return createResponse(TRouteResult.UNKNOWN);
143132
}
144133

145-
private ClientStreamChannel createStreamChannel(ThriftAgentConnection clusterPoint, byte[] payload, ClientStreamChannelEventHandler streamChannelEventHandler) throws StreamException {
146-
PinpointServer pinpointServer = clusterPoint.getPinpointServer();
147-
return pinpointServer.openStreamAndAwait(payload, streamChannelEventHandler, 3000);
148-
}
149-
150134
public void close(ServerStreamChannel consumerStreamChannel) {
151135
Object attachmentListener = consumerStreamChannel.getAttribute(ATTACHMENT_KEY);
152136

collector/src/main/java/com/navercorp/pinpoint/collector/handler/thrift/ThriftAgentEventHandler.java

-120
This file was deleted.

collector/src/main/java/com/navercorp/pinpoint/collector/handler/thrift/ThriftAgentInfoHandler.java

-94
This file was deleted.

0 commit comments

Comments
 (0)