Skip to content

Commit 8d18b76

Browse files
committed
[pinpoint-apm#9932] Removed thrift dependency of Agent module
1 parent a49d3cc commit 8d18b76

File tree

4 files changed

+26
-25
lines changed

4 files changed

+26
-25
lines changed

profiler-thrift/src/main/java/com/navercorp/pinpoint/profiler/thrift/sender/RequestMessage.java

+3-5
Original file line numberDiff line numberDiff line change
@@ -16,19 +16,17 @@
1616

1717
package com.navercorp.pinpoint.profiler.thrift.sender;
1818

19-
import com.navercorp.pinpoint.rpc.ResponseMessage;
20-
2119
import java.util.function.BiConsumer;
2220

2321
/**
2422
* @author Woonduk Kang(emeroad)
2523
*/
26-
public interface RequestMessage<M> {
24+
public interface RequestMessage<REQ, RES> {
2725

28-
M getMessage();
26+
REQ getMessage();
2927

3028
int getRetryCount();
3129

32-
BiConsumer<ResponseMessage, Throwable> getFutureListener();
30+
BiConsumer<RES, Throwable> getFutureListener();
3331

3432
}

profiler-thrift/src/main/java/com/navercorp/pinpoint/profiler/thrift/sender/RequestMessageFactory.java

+3-5
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
package com.navercorp.pinpoint.profiler.thrift.sender;
1818

1919

20-
import com.navercorp.pinpoint.rpc.ResponseMessage;
21-
2220
import java.util.function.BiConsumer;
2321

2422
/**
@@ -29,11 +27,11 @@ public final class RequestMessageFactory {
2927
private RequestMessageFactory() {
3028
}
3129

32-
public static <T> RequestMessage<T> request(T message, int retryCount) {
33-
return new RetryRequestMessage<>(message, retryCount, null);
30+
public static <T, R> RequestMessage<T, R> request(T message, int retryCount) {
31+
return new RetryRequestMessage<>(message, retryCount);
3432
}
3533

36-
public static <T> RequestMessage<T> request(T message, int retryCount, BiConsumer<ResponseMessage, Throwable> futureListener) {
34+
public static <T, R> RequestMessage<T, R> request(T message, int retryCount, BiConsumer<R, Throwable> futureListener) {
3735
return new RetryRequestMessage<>(message, retryCount, futureListener);
3836
}
3937

profiler-thrift/src/main/java/com/navercorp/pinpoint/profiler/thrift/sender/RetryRequestMessage.java

+15-10
Original file line numberDiff line numberDiff line change
@@ -16,28 +16,33 @@
1616

1717
package com.navercorp.pinpoint.profiler.thrift.sender;
1818

19-
import com.navercorp.pinpoint.rpc.ResponseMessage;
20-
19+
import java.util.Objects;
2120
import java.util.function.BiConsumer;
2221

2322
/**
2423
* @author Woonduk Kang(emeroad)
2524
*/
26-
class RetryRequestMessage<T> implements RequestMessage<T> {
27-
private final T message;
25+
class RetryRequestMessage<REQ, RES> implements RequestMessage<REQ, RES> {
26+
private final REQ message;
2827
private final int retryCount;
29-
private final BiConsumer<ResponseMessage, Throwable> futureListener;
28+
private final BiConsumer<RES, Throwable> futureListener;
29+
3030

31+
RetryRequestMessage(REQ message, int retryCount) {
32+
this.message = Objects.requireNonNull(message, "message");
33+
this.retryCount = retryCount;
34+
this.futureListener = null;
35+
}
3136

32-
RetryRequestMessage(T message, int retryCount, BiConsumer<ResponseMessage, Throwable> futureListener) {
33-
this.message = message;
37+
RetryRequestMessage(REQ message, int retryCount, BiConsumer<RES, Throwable> futureListener) {
38+
this.message = Objects.requireNonNull(message, "message");
3439
this.retryCount = retryCount;
35-
this.futureListener = futureListener;
40+
this.futureListener = Objects.requireNonNull(futureListener, "futureListener");
3641
}
3742

3843

3944
@Override
40-
public T getMessage() {
45+
public REQ getMessage() {
4146
return message;
4247
}
4348

@@ -47,7 +52,7 @@ public int getRetryCount() {
4752
}
4853

4954
@Override
50-
public BiConsumer<ResponseMessage, Throwable> getFutureListener() {
55+
public BiConsumer<RES, Throwable> getFutureListener() {
5156
return futureListener;
5257
}
5358
}

profiler-thrift/src/main/java/com/navercorp/pinpoint/profiler/thrift/sender/TcpDataSender.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -175,13 +175,13 @@ public boolean request(T data) {
175175

176176
@Override
177177
public boolean request(T data, int retryCount) {
178-
final RequestMessage<?> message = RequestMessageFactory.request(data, retryCount);
178+
final RequestMessage<T, ResponseMessage> message = RequestMessageFactory.request(data, retryCount);
179179
return executor.execute(message);
180180
}
181181

182182
@Override
183183
public boolean request(T data, BiConsumer<ResponseMessage, Throwable> listener) {
184-
final RequestMessage<T> message = RequestMessageFactory.request(data, 3, listener);
184+
final RequestMessage<T, ResponseMessage> message = RequestMessageFactory.request(data, 3, listener);
185185
return executor.execute(message);
186186
}
187187

@@ -211,8 +211,8 @@ public void stop() {
211211

212212
protected void sendPacket(Object message) {
213213
try {
214-
if (message instanceof RequestMessage<?>) {
215-
final RequestMessage<T> requestMessage = (RequestMessage<T>) message;
214+
if (message instanceof RequestMessage<?, ?>) {
215+
final RequestMessage<T, ResponseMessage> requestMessage = (RequestMessage<T, ResponseMessage>) message;
216216
if (doRequest(requestMessage)) {
217217
return;
218218
}
@@ -229,7 +229,7 @@ protected void sendPacket(Object message) {
229229
}
230230
}
231231

232-
private boolean doRequest(RequestMessage<T> requestMessage) {
232+
private boolean doRequest(RequestMessage<T, ResponseMessage> requestMessage) {
233233
final T message = requestMessage.getMessage();
234234

235235
final byte[] copy = messageSerializer.serializer(message);

0 commit comments

Comments
 (0)