Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename #embroider_compat/* to @embroider/virtual/* #2028

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BlueCutOfficial
Copy link
Collaborator

@BlueCutOfficial BlueCutOfficial commented Jul 5, 2024

Fixes #2026

@BlueCutOfficial BlueCutOfficial changed the title Rename hashtag compat Rename #embroider_compat/* to @embroider/virtual/* Jul 5, 2024
@ef4
Copy link
Contributor

ef4 commented Jul 5, 2024

This is not going to be necessary. I have confirmed that we can do all this resolution from our esbuild resolver plugin before vite's depscan plugin sees them.

@ef4
Copy link
Contributor

ef4 commented Jul 5, 2024

(I'm not opposed to making the change for purely aesthetic reasons, if we want all our virtual stuff to match under one namespace. But we thought this would be necessary to get vite to respect these as potentially external deps, and that is not correct.)

@BlueCutOfficial BlueCutOfficial marked this pull request as ready for review July 9, 2024 08:31
@BlueCutOfficial
Copy link
Collaborator Author

I have no strong opinion, we have this PR ready and it has the benefit of slightly simplifying the code in shared-internals/src/paths.ts 🤷‍♀️ As you like really, feel free to merge or close.

@BlueCutOfficial
Copy link
Collaborator Author

Discussed with Chris: this PR brings value but we should wait for #2029 because it brings tests regarding dependencies making their way to Vite deps.

@BlueCutOfficial
Copy link
Collaborator Author

@mansona rebased on main :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename #embroider_compat/* to @embroider/virtual/*
3 participants