Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to move the implementation of updateAppJS to the virtual files in compat-app-builder.ts #2022

Open
BlueCutOfficial opened this issue Jul 5, 2024 · 0 comments

Comments

@BlueCutOfficial
Copy link
Collaborator

The point of this task is that right now we need to define the engine config (that goes into the resolver.json) as part of stage 2. It would be better if stage 3 was more responsive about this and didn't rely on an engine's config that is generated early.

We definitely don't want to rely on any file crawling that happens in stage 2 (i.e. if the engine's config lists any files we should not rely on that in stage 3) but I think we might have solved this already 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant