Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rewritten appJS into an app folder (to reduce the diff) and rely on exports to resolve correctly #1959

Open
mansona opened this issue Jun 5, 2024 · 0 comments

Comments

@mansona
Copy link
Member

mansona commented Jun 5, 2024

Context

We want to remove any diff between the Ember app and the rewritten-app so Vite consumes the first directly and the latter can be deactivated.

One of the differences is that files located in my-ember-app/app/* are moved directly to the root of the rewritten-app, because Vite wants the index.html to be at the root. We should find a way to keep the current hierarchy of the Ember app.

In-progress solution

pushed as branch wip-app-namespacing

https://github.com/embroider-build/embroider/tree/wip-app-namespacing

@BlueCutOfficial BlueCutOfficial changed the title move rewritten appJS into an app folder (to reduce the diff) and rely on exports to resolve correctly Move rewritten appJS into an app folder (to reduce the diff) and rely on exports to resolve correctly Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant