Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree passed to preprocessors for app and addon is not scoped with moduleName #1206

Closed
wondersloth opened this issue May 19, 2022 · 1 comment

Comments

@wondersloth
Copy link
Contributor

Replicated the issue here:
https://github.com/wondersloth/demo-embroider-preprocessors-bug

When a preprocessor is run on an app or addon, the tree isn't scoped with the moduleName.

This creates backcompat issues with addons like ember-css-modules that uses the file path to generate hash for some values.

screenshot

@ef4
Copy link
Contributor

ef4 commented Jun 20, 2022

Closed in #1205.

@ef4 ef4 closed this as completed Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants