Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should assets referenced in templates be fingerprinted during production builds? #1139

Open
NullVoxPopuli opened this issue Feb 24, 2022 · 0 comments

Comments

@NullVoxPopuli
Copy link
Collaborator

Potentially related issues:

I have this PR (and this simpler example)
Which isn't anything new, both before and after the use of css' @import and usage of <link> tags in components, my style paths are not correctly transformed during the production build, leading to 404s in production.

Things I've tried to see if I was maybe just formatting the paths incorrectly:

<style>
  @import "/assets/tailwind.css";
</style>
<link rel="stylesheet" href="/assets/tailwind.css">

with and without leading /

console.log({ a: '/assets/tailwind.css', b: 'assets/tailwind.css' });

my production build output (dist/assets):
image

If I were to debug embroider looking for where we expect transformation to happen, but maybe there is just a bug, how/where would I look?
(is that even implemented atm?, I don't recall seeing any code that transforms all templates looking for assets, but I could have missed it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant