-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifying SASS files triggers full reload since 2.6.2 #577
Comments
We are noticing this as well, on Editing an scss file causes both the When I look at the websocket traffic to livereload I see reload commands for chunks generated by ember-auto-import, as well as the reload command for my app.css. The question then, is why does |
I tried downgrading to On 2.6.1 after editing an scss file I still see both The websocket traffic now only shows a reload command for app.css. The reload commands for various chunk.js generated by ember-auto-import are now gone. I think that confirms that this issue was introduced by 2.6.2 and not fixed by 2.6.3. I looked at the diff between 2.6.2 and 2.6.1, but it was a bit over my head. Does anyone with more familiarity in this codebase have some ideas why that diff causes this regression? |
Since 2.6.2 the code writes new js-files for each build https://github.com/embroider-build/ember-auto-import/blob/v2.6.3/packages/ember-auto-import/ts/webpack.ts#L366 These files don't get cached like in https://github.com/embroider-build/ember-auto-import/blob/v2.6.3/packages/ember-auto-import/ts/inserter.ts#L228 From my testing .. caching these files should solve the reload problem.. |
Also ran into this after an upgrade. Downgrading to 2.6.1 seems to have fixed it. |
However, it looks like even if I just make changes to
This was when I only changed a typescript file. Still better than a page reload on simple CSS changes. |
Hello everyone, |
This is still happening with ember-auto-import 2.7.2, though a new app with embroider doesn't have this problem. |
Having the same issue on my Ember projects |
This is still happening with ember-auto-import 2.7.4 and I cannot downgrade to 2.6.1, while using ember 5.8.0, |
Hi there,
modifying a SASS file causes full page reload instead of CSS livereload in Ember since ember-auto-import 2.6.2. It wasn't the case when I was using 2.6.1 previously.
Thx
The text was updated successfully, but these errors were encountered: