From 13d5e0654bb361f1172a410c20c7a79f1a77b18d Mon Sep 17 00:00:00 2001 From: Tobias Bieniek Date: Fri, 15 Nov 2019 12:52:09 +0100 Subject: [PATCH] [BUGFIX release] Add component reference to the mouse event handler deprecation warnings This makes the deprecations a lot more actionable because it's easier to see what component is causing the deprecation without having to open the debugger. --- packages/@ember/-internals/glimmer/lib/component.ts | 6 +++--- .../glimmer/tests/integration/event-dispatcher-test.js | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/@ember/-internals/glimmer/lib/component.ts b/packages/@ember/-internals/glimmer/lib/component.ts index 5086f71b45c..a3c8fc8de5a 100644 --- a/packages/@ember/-internals/glimmer/lib/component.ts +++ b/packages/@ember/-internals/glimmer/lib/component.ts @@ -747,7 +747,7 @@ const Component = CoreView.extend( } deprecate( - `Using \`mouseEnter\` event handler methods in components has been deprecated.`, + `${this}: Using \`mouseEnter\` event handler methods in components has been deprecated.`, this.mouseEnter === undefined, { id: 'ember-views.event-dispatcher.mouseenter-leave-move', @@ -756,7 +756,7 @@ const Component = CoreView.extend( } ); deprecate( - `Using \`mouseLeave\` event handler methods in components has been deprecated.`, + `${this}: Using \`mouseLeave\` event handler methods in components has been deprecated.`, this.mouseLeave === undefined, { id: 'ember-views.event-dispatcher.mouseenter-leave-move', @@ -765,7 +765,7 @@ const Component = CoreView.extend( } ); deprecate( - `Using \`mouseMove\` event handler methods in components has been deprecated.`, + `${this}: Using \`mouseMove\` event handler methods in components has been deprecated.`, this.mouseMove === undefined, { id: 'ember-views.event-dispatcher.mouseenter-leave-move', diff --git a/packages/@ember/-internals/glimmer/tests/integration/event-dispatcher-test.js b/packages/@ember/-internals/glimmer/tests/integration/event-dispatcher-test.js index cac0ca4aa38..8f1cce38c5c 100644 --- a/packages/@ember/-internals/glimmer/tests/integration/event-dispatcher-test.js +++ b/packages/@ember/-internals/glimmer/tests/integration/event-dispatcher-test.js @@ -403,7 +403,7 @@ moduleFor( }); expectDeprecation( - 'Using `mouseMove` event handler methods in components has been deprecated.' + /Using `mouseMove` event handler methods in components has been deprecated\./ ); this.render(`{{x-foo}}`);