From 474fbf7f19cfde55450b3c7c04bec288d6c6f741 Mon Sep 17 00:00:00 2001 From: Nathan Hammond Date: Tue, 30 Jun 2015 09:37:43 -0700 Subject: [PATCH] [BUGFIX] Add return statement for extend. Results in the value being `undefined` after an `extend` call. --- .../ember-routing-htmlbars/tests/helpers/link-to_test.js | 9 +++++++++ packages/ember-routing-views/lib/views/link.js | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/packages/ember-routing-htmlbars/tests/helpers/link-to_test.js b/packages/ember-routing-htmlbars/tests/helpers/link-to_test.js index e0ca14c2368..ec46428c417 100644 --- a/packages/ember-routing-htmlbars/tests/helpers/link-to_test.js +++ b/packages/ember-routing-htmlbars/tests/helpers/link-to_test.js @@ -132,6 +132,15 @@ QUnit.test("reopening on LinkView actually reopens on LinkComponent", function() }); +QUnit.test("Extending a LinkView returns a LinkView.", function() { + expect(2); + + expectDeprecation(function() { + var result = Ember.LinkView.extend({}); + equal(result.toString(), '(subclass of Ember.LinkView)', 'Returns a subclass of the Ember.LinkView object.'); + }); +}); + QUnit.test("unwraps controllers", function() { var template = "{{#link-to 'index' view.otherController}}Text{{/link-to}}"; diff --git a/packages/ember-routing-views/lib/views/link.js b/packages/ember-routing-views/lib/views/link.js index bd3ded91c32..2576e6f7f7d 100644 --- a/packages/ember-routing-views/lib/views/link.js +++ b/packages/ember-routing-views/lib/views/link.js @@ -522,7 +522,7 @@ DeprecatedLinkView.reopen = function reopenWithDeprecation() { DeprecatedLinkView.reopenClass({ extend: function () { Ember.deprecate('Ember.LinkView is deprecated. Please extend from Ember.LinkComponent.', false); - this._super.apply(this, arguments); + return this._super.apply(this, arguments); } });