-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory leak issue when transitioning from route. #4541
Comments
@machty something else up your alley! |
Same behaviour here. But I'm not sure if this is a bug. Is ember willingly keeping those detached DOM tree ? |
I suspect this will be improved by HTMLBars. |
@Yogananthan |
This is definitely not fixed (or a new but very similar memory leak has arisen in 1.13). My symptoms are very similar to Yogananthan's, including the leaked DOM trees proportional to the size of the templates involved. Here's a github demo: https://github.snei.sony.com/ahare/leaky-app Just follow the readme.md for setup instructions. Checkout commit 4fd324f829 to watch it leak a big component on every transition. Here's my stackoverflow post where it was encouraged I post here instead: http://stackoverflow.com/questions/32332957/memory-leak-on-route-transition-in-very-simple-ember-1-13-app?noredirect=1#comment52542584_32332957 |
@arthare can you open a new issue. And be sure to test on the latest 1.13 and also 2.0 |
K, will do. |
Updated to 2.0.1, and it is fixed. I guess that'll do for now. |
There is a memory leak while navigating from one route to another.
While transitioning to a route, the entire DOM of the previous rendered template gets added to the detached DOM tree increasing the memory consumed. This increases as the no.of nodes in that template increases.
Here is a JsBin illustrating the issue. Steps to reproduce:
1. Enter the
test
route directly.384 new nodes (the no.of nodes in the
test
template) gets added to the detached DOM treeThe issue seems to occur due to Ember.Select
The text was updated successfully, but these errors were encountered: