[Bug] Assertion in link-component is incorrectly running when using link-to-external

[hmajoros]

🐞 Describe the Bug

This change was added to provide better boundaries for linking inside/between engines with the <LinkTo> component. However, link-to-external extends link-component, and thus this assertion runs on the init of any LinkToExternal usage. When inside of a routeless engine, there is currently no way to link out, as both <LinkTo> and <LinkToExternal> throw this assertion.

🔬 Minimal Reproduction

Using ember-engines, create a routeless engine & use <LinkToExternal> inside this routeless engine

😕 Actual Behavior

Assertion fails when using link-to-external inside of a routeless engine

🤔 Expected Behavior

routeless engines should allow the usage of link-to-externala

🌍 Environment

• Ember: 3.24.3
• Node.js/npm: 14.15.1
• OS: Big Sur
• Browser: All

➕ Additional Context

[hmajoros]

@chancancode I think the best way to fix this is to move this assertion check into a method inside link-component, and then have link-to-external overwrite this method with a noop. Thoughts?

[rwjblue]

@hmajoros - Ya, that seems ok to me (I really do want to get rid of <LinkToExternal /> all together, that is just a massively different problem 😝 ). Happy to land + backport a fix for this.

[hmajoros]

ember.js PR: #19477
ember-engines PR: ember-engines/ember-engines#761

[hmajoros]

Closing issue as both ember & ember-engines fixes have now landed & been backported to 3.24.