Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The [email protected] published module is broken #18575

Closed
kanongil opened this issue Nov 25, 2019 · 3 comments
Closed

The [email protected] published module is broken #18575

kanongil opened this issue Nov 25, 2019 · 3 comments

Comments

@kanongil
Copy link
Contributor

kanongil commented Nov 25, 2019

The published dist/legacy/ember.*.js uses const, which carries over to the ember-cli built vendor.js and causes it to break on eg. iOS 9.3.5 devices.

It seems that this is a babel issue in the ember-source publication process. A number of lines containing const data = _taggedTemplateLiteralLoose(…); is left in the files.
It seems that babel fails to properly apply const => var for tagged template literals.

I have not checked older versions than 3.12.1. For 3.13+ it works again due to a revised build process.

@kanongil
Copy link
Contributor Author

kanongil commented Nov 25, 2019

I checked the published packages, and this issue seems to have been introduced with [email protected]. The [email protected] package does not contain const expressions.

@kanongil
Copy link
Contributor Author

Seems that this was introduced with #17859.

@rwjblue
Copy link
Member

rwjblue commented Dec 4, 2019

Fixed by #18576 and being released as v3.12.2 (currently pending CI for publishing).

@rwjblue rwjblue closed this as completed Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants