-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Descendants of "Template-only components" has wrong _targetObject
#15977
Comments
_targetObject
I found the bug. The problem is that the (curly) component tries to point its @rwjblue @krisselden what should be the right semantics here? (It is only tangentially related the ember-inspector in that it is trying to use |
I mentioned this in slack, but just wanted to clarify here also. I do not believe this is a bug in the feature. Having a |
@chancancode / @kategengler - Did we decide that this wasn't an issue, or is there still something that needs addressing here? |
I haven't checked the inspector's current behavior yet, but if it still does not show the tree of components beneath the template-only component, I'd say that's a problem. |
@chancancode @kategengler @rwjblue is this still an issue, perhaps we should close or create a new reproduction of this, what do you think? |
I believe this is still an issue; we discussed it just last Thursday at the Release team meeting. |
Concretely, the issue is that the inspector currently does not support displaying these files (the description here is out of date IMHO). |
Maybe we could migrate to emberjs/ember-inspector#870 though? |
@rwjblue I'm fine with tracking in inspector, we definitely need a game plan to support all the various possible component types, tagless, template only, etc. |
Tracking at Ember Inspector. |
As discussed here: emberjs/rfcs#278 (comment)
For convenience sake, here is a demo app using Ember canary and a tree of:
Partials are not visible in the tree in the Ember Inspector but components beneath them are visible. Template-only components are not visible in the Ember Inspector, as expected, but regular components used in those template-only components are also not visible (unexpected).
Edit: added link to demo app, oops
The text was updated successfully, but these errors were encountered: