Ember 2.16 router service unable to transition without all query parameters present

[pgrippi]

I upgraded my app from 2.15 to 2.16 today and I think I've found a bug with the transitionTo method in the new routing service.

In 2.15 I was using the ember-router-service-polyfill addon that I have since removed. The following code was working fine but now appears to be broken:

// controller
import Controller from '@ember/controller';

export default Controller.extend({
  queryParams: ['page', 'message'],
  page: 1,
  message: ''
});

// component
import Component from '@ember/component';
import { inject as service } from '@ember/service';

export default Component.extend({
  router: service(),

  actions: {
    jump() {
      let queryParams = { message: 'hello world!' };
      this.get('router').transitionTo('index', { queryParams });
    }
  }
});

The error I get in the jump action is: "You passed the false query parameter during a transition into index, please update to page", which I've narrowed down to be coming from this line in router.js.

It does end up working if I include both message and page in the query params hash. In short:

// broken
this.get('router').transitionTo('index', { queryParams: { message: '' } });
this.get('router').transitionTo('index', { queryParams: { page: 1 } });
this.get('router').transitionTo('index');

// works
this.get('router').transitionTo('index', { queryParams: { message: '', page: 1 } });

I have created this app that shows the broken behavior: https://github.com/pgrippi/ember-216-routing-service-bug

[hellobrett]

We are also being affected by this issue. Any chance for a patch release?

[sly7-7]

@hellobrett seems like there will be soon one: #15613 (comment)

@rwjblue maybe we can close this issue ?

[rwjblue]

Thanks @sly7-7!