Query param is sticky for different route model in routeable ember-engine

[rajaalauddin]

I have reproduced this issue in this repo https://github.com/rajaalauddin/ember-engines-demo

Sample steps on how to reproduce the issue:

1. Create a route inside routable ember engine with dynamic segment. e.g /viewers/:id
2. Create link-to /viewers/2 for viewers.hbs template
3. Add query param to viewer controller e.g queryParams: ['active']
4. Go to /viewers/1?active=true
5. See how link-to generated on /viewers/2 also has the query param e.g /viewers/2?active=true

These are not the case when done outside engine.

Another developer and i have traced this issue down to how calculateCacheKey is called.

var cacheKey = _emberRoutingUtils.calculateCacheKey(aQp.controllerName, aQp.parts, aQp.values);

Changing the above to:

var cacheKey = _emberRoutingUtils.calculateCacheKey(aQp.route.fullRouteName, aQp.parts, aQp.values);

fixed the problem for us. Let me know if this is the correct solution so that i can create a pull request.

[rwjblue]

Thanks for reporting!

Let me know if this is the correct solution so that i can create a pull request

The solution seems reasonable in general (specifically, we need to ensure that the cache key is built up correctly inside the engine). I think the next step is getting an isolated failing test case.

Please take a look at some of these engine tests tests for an idea of how to set it up. I believe we should be able to add a test in that file that replicates the scenario you describe in the issue description.

[rajaalauddin]

I have written the failing test case with the fix in one commit below.
rajaalauddin@7672ec9

It was originally failing but now passed after my change

[pixelhandler]

@rajaalauddin perhaps make a PR for the failing test? And the fix too :)

[rajaalauddin]

@pixelhandler I have created pull request here #14794

[Serabe]

Closed via #14794