Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Beta Bug] Intermixing attrs and non-attrs on closure actions become mutable cells #14379

Closed
chadhietala opened this issue Sep 29, 2016 · 3 comments

Comments

@chadhietala
Copy link
Contributor

Repro:
https://ember-twiddle.com/1be97289c3f77efac3ac851a22626595?openFiles=templates.application.hbs%2Ctemplates.components.my-middleman.hbs

I'm not sure how we did this before in HTMLBars, but when you go from foo=(action 'foo') and pass it to child as fooAction and that child tries to call it as this.attrs.fooAction, it will be a MutableCell and not the actual closure action.

@chadhietala chadhietala added this to the 2.9.0 milestone Sep 29, 2016
@rwjblue
Copy link
Member

rwjblue commented Sep 29, 2016

@chadhietala - I believe this issue is basically what I have submitted a failing test PR in #13996 for. Can you confirm?

@chadhietala
Copy link
Contributor Author

Yes

@rwjblue
Copy link
Member

rwjblue commented Oct 3, 2016

Fixed by #13996

@rwjblue rwjblue closed this as completed Oct 3, 2016
@rwjblue rwjblue reopened this Oct 3, 2016
@rwjblue rwjblue closed this as completed Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants