Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add acceptance test for getHandler returning a Promise #14099

Closed
trentmwillis opened this issue Aug 19, 2016 · 2 comments
Closed

Add acceptance test for getHandler returning a Promise #14099

trentmwillis opened this issue Aug 19, 2016 · 2 comments
Labels
Engines

Comments

@trentmwillis
Copy link
Member

Ref: #14087

We should add a test to make sure that everything works properly with Router#getHandler returning a Promise to ensure compatibility with Engines. This is currently blocked by figuring the best strategy for dealing with default query params in this scenario.
@rwjblue
Copy link
Member

rwjblue commented Aug 31, 2016

/cc @dgeb

@rwjblue
Copy link
Member

rwjblue commented Nov 10, 2016

Added in #14471

@rwjblue rwjblue closed this as completed Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Engines
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rwjblue @pixelhandler @trentmwillis