Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view._renderNode.lastResult giving "Uncaught TypeError: Cannot read property 'lastResult' of null" #13968

Closed
kellyselden opened this issue Jul 30, 2016 · 7 comments

Comments

@kellyselden
Copy link
Member

kellyselden commented Jul 30, 2016

I have unsuccessful in tracking this down so far. A few days ago when canary ticked over to beta, I noticed that canary the whole time and now beta are failing for my addon:

Uncaught TypeError: Cannot read property 'lastResult' of null
Renderer_revalidateTopLevelView @ ember.debug.js:14397
exports.default._emberMetalMixin.Mixin.create._Mixin$create.revalidate @ ember.debug.js:42831
invoke @ ember.debug.js:990
flush @ ember.debug.js:1054
flush @ ember.debug.js:862
end @ ember.debug.js:176
(anonymous function) @ ember.debug.js:742

Here is one of the travis build logs https://travis-ci.org/kellyselden/ember-tree/builds/148237768. I tried removing dependencies to narrow it down, but then tests start failing for other reasons.

When debugging, if (view._renderNode.lastResult) { passes through the first time, then fails on the second. I inspected view and although it doesn't have a _renderNode property, it does have a lastResult property. I don't know if that helps.

@krisselden
Copy link
Contributor

_renderNode is private and not part of glimmer2

@kellyselden
Copy link
Member Author

OK, but I don't know how I'm causing this failure. I'm not using any private code in my addon code, maybe one of the addons I'm using is having issues with glimmer 2. My ember debugging skills are apparently lacking in this case.

@kellyselden
Copy link
Member Author

This is still happening. Would you say it's probably an addon I'm using that's using an old htmlbars version? Any debugging tips are appreciated! cc @krisselden

@rwjblue
Copy link
Member

rwjblue commented Aug 22, 2016

It should be fixed by #14110.

@kellyselden
Copy link
Member Author

@rwjblue Using that branch, it didn't seem to fix it: https://travis-ci.org/kellyselden/ember-tree/jobs/154205905

@rwjblue
Copy link
Member

rwjblue commented Aug 22, 2016

@kellyselden - Sorry, I forgot to update the bower tree after my last commit. Can you blow cache and test again?

@kellyselden
Copy link
Member Author

@rwjblue Works now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants