Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QP does not get updated when model is refreshed #13263

Closed
lan0 opened this issue Apr 5, 2016 · 4 comments
Closed

QP does not get updated when model is refreshed #13263

lan0 opened this issue Apr 5, 2016 · 4 comments

Comments

@lan0
Copy link
Contributor

lan0 commented Apr 5, 2016

Since 2.4.4 the query parameter does not get updated when refreshing the route.

See this twiddle: https://ember-twiddle.com/48d144fbb71cb96220e42dbd664eaef3 (works in 2.4.3 but not in 2.4.4)

I think this is because of #13202, after the second click the content of queryParams is {foo: "2", application:foo: 3} here. Subsequent changes on the QP increment application:foo but not foo.

@rwjblue
Copy link
Member

rwjblue commented Apr 5, 2016

/cc @raytiley

@pixelhandler
Copy link
Contributor

@raytiley
Copy link
Contributor

raytiley commented Apr 8, 2016

@pixelhandler thanks... I actually have an in-progress fix for this: #13273

I'm going to tidy it up / test it etc this weekend

@lan0
Copy link
Contributor Author

lan0 commented Jun 10, 2016

Closing because of #13600

@lan0 lan0 closed this as completed Jun 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants