Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember 1.13.7: click events in components are not triggered #12063

Closed
MichaelVdheeren opened this issue Aug 12, 2015 · 5 comments
Closed

Ember 1.13.7: click events in components are not triggered #12063

MichaelVdheeren opened this issue Aug 12, 2015 · 5 comments

Comments

@MichaelVdheeren
Copy link

export default Em.Component.extend({
  tagName: 'a',
  classNames: ['btn', 'btn_primary'],
  classNameBindings: ['disabled'],

  click: function(){
    this.sendAction();
  },
});

The click is not triggered when clicking on the component in 1.13.7. This works in 1.13.6

@rwjblue
Copy link
Member

rwjblue commented Aug 12, 2015

Seems to be working here: http://emberjs.jsbin.com/dumura/edit?html,js,output.

How are you invoking the component?

@MichaelVdheeren
Copy link
Author

{{save-button action="sendInvite" disabled=canNotSend classNames="btn btn_primary pull-right" regularText=regularText disabledText=disabledText}}

@MichaelVdheeren
Copy link
Author

Doesn't work here, classNames problem
http://emberjs.jsbin.com/fodifofeba/edit?html,js,output

@rwjblue
Copy link
Member

rwjblue commented Aug 12, 2015

Gotcha, then this isn't about declaration of your component, it is about invocation. Switching to class= instead of classNames= should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants