Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Ember.get #11733

Closed
3 tasks done
mmun opened this issue Jul 13, 2015 · 5 comments
Closed
3 tasks done

Cleanup Ember.get #11733

mmun opened this issue Jul 13, 2015 · 5 comments
Labels

Comments

@mmun
Copy link
Member

mmun commented Jul 13, 2015

  • Remove support for globals: Ember.get('App.foo') and Ember.get(null, 'App.foo')
  • Remove support for this: Ember.get(object, 'this.foo')
  • Enforce strict usage with two arguments: Ember.get(object, path)
    • assert object is a non-null object & path is a string.
@mmun mmun added the Cleanup label Jul 13, 2015
@ghost
Copy link

ghost commented Jul 14, 2015

I'm going to take a stab at this, if that's ok.

@stefanpenner
Copy link
Member

I'm going to take a stab at this, if that's ok.

ofcourse :)

@btecu
Copy link
Contributor

btecu commented Jul 14, 2015

Does this mean this.get('foo') will be deprecated?

@stefanpenner
Copy link
Member

@btecu no

@ghost
Copy link

ghost commented Jul 15, 2015

Does Ember.set require the same cleanup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants