Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.13.0-beta.1] View context changed on {{each}} #11199

Closed
igorsantos07 opened this issue May 18, 2015 · 1 comment · Fixed by #11234
Closed

[1.13.0-beta.1] View context changed on {{each}} #11199

igorsantos07 opened this issue May 18, 2015 · 1 comment · Fixed by #11234
Labels
Milestone

Comments

@igorsantos07
Copy link

When upgrading from 1.12 to 1.13, more than deprecation warnings, I saw a breaking change (bug?) in View context handling on {{each}}. JSBin sample is here.

In short:
Main template: {{each item in model itemViewClass='sample'}}
Sample view template: <p>1.12: {{item.name}} || 1.13: {{name}}</p>

On 1.12 the view's context would contain the iteration instance item. On 1.13 that's not there anymore, as that instance is itself the view context.

I saw nothing on this matter on docs, changelogs or deprecations list. Am I blindly searching or is this a real issue for who's moving to 1.13?

@igorsantos07 igorsantos07 changed the title [1.13.0-beta.1] View scope changing on {{each}} [1.13.0-beta.1] View context changed on {{each}} May 18, 2015
@rwjblue
Copy link
Member

rwjblue commented May 18, 2015

No, this is a bug and it should be fixed before 1.13.0 is final.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants