Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include features.json in development build #10212

Closed
tomdale opened this issue Jan 13, 2015 · 1 comment · Fixed by #10221
Closed

Include features.json in development build #10212

tomdale opened this issue Jan 13, 2015 · 1 comment · Fixed by #10221
Assignees
@rwjblue

Comments

@tomdale
Copy link
Member

tomdale commented Jan 13, 2015

Currently, doing a dev build of Ember.js does not take features.json into account. This is bad because it means that there will be features missing, even those that have been promoted to the beta channel. This is exacerbated on master right now due to the fact that Handlebars support has been removed, but HTMLbars is still behind a feature flag, so development builds are broken out of the box.

(This ticket filed at the request of @rwjblue.)
@twokul
Copy link
Member

twokul commented Jan 13, 2015

@tomdale @rwjblue should we move this issue to emberjs-build?

@rwjblue rwjblue mentioned this issue Jan 15, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwjblue rwjblue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Embed enabled features in debug builds. rwjblue/ember.js
3 participants
@rwjblue @tomdale @twokul