removes transaction renderer

Author: Chris Garrett

packages/@ember/-internals/glimmer/lib/renderer.ts

@@ -1,5 +1,5 @@
 import { ENV } from '@ember/-internals/environment';
-import { runInAutotrackingTransaction, runInTransaction } from '@ember/-internals/metal';
+import { runInAutotrackingTransaction } from '@ember/-internals/metal';
 import { getViewElement, getViewId } from '@ember/-internals/views';
 import { assert } from '@ember/debug';
 import { backburner, getCurrentRunLoop } from '@ember/runloop';
@@ -432,9 +432,7 @@ export abstract class Renderer {
           root.options.alwaysRevalidate = shouldReflush;
           // track shouldReflush based on this roots render result
           if (DEBUG) {
-            runInAutotrackingTransaction(() => {
-              shouldReflush = root.shouldReflush = runInTransaction(root, 'render');
-            });
+            runInAutotrackingTransaction(() => root.render());
           } else {
             root.render();
           }

packages/@ember/-internals/glimmer/lib/utils/references.ts

@@ -1,6 +1,5 @@
 import {
   consume,
-  didRender,
   get,
   set,
   tagFor,
@@ -16,7 +15,6 @@ import { DEBUG } from '@glimmer/env';
 import { Dict, Opaque } from '@glimmer/interfaces';
 import {
   combine,
-  COMPUTE,
   ConstReference,
   createTag,
   createUpdatableTag,
@@ -105,32 +103,6 @@ export class RootReference<T extends object> extends ConstReference<T>
   }
 }
 
-let TwoWayFlushDetectionTag: {
-  create(tag: Tag, key: string, ref: VersionedPathReference<Opaque>): Tag;
-};
-
-if (DEBUG) {
-  TwoWayFlushDetectionTag = class TwoWayFlushDetectionTag {
-    static create(tag: Tag, key: string, ref: VersionedPathReference<Opaque>): Tag {
-      return (new TwoWayFlushDetectionTag(tag, key, ref) as unknown) as Tag;
-    }
-
-    constructor(
-      private tag: Tag,
-      private key: string,
-      private ref: VersionedPathReference<Opaque>
-    ) {}
-
-    [COMPUTE](): Revision {
-      return this.tag[COMPUTE]();
-    }
-
-    didCompute(parent: Opaque): void {
-      didRender(parent, this.key, this.ref);
-    }
-  };
-}
-
 export abstract class PropertyReference extends CachedReference {
   abstract tag: Tag;
 
@@ -162,11 +134,7 @@ export class RootPropertyReference extends PropertyReference
       update(tag, tagForProperty(parentValue, propertyKey));
     }
 
-    if (DEBUG) {
-      this.tag = TwoWayFlushDetectionTag.create(this.propertyTag, propertyKey, this);
-    } else {
-      this.tag = this.propertyTag;
-    }
+    this.tag = this.propertyTag;
 
     if (DEBUG && !EMBER_METAL_TRACKED_PROPERTIES) {
       watchKey(parentValue, propertyKey);
@@ -176,10 +144,6 @@ export class RootPropertyReference extends PropertyReference
   compute(): Opaque {
     let { parentValue, propertyKey } = this;
 
-    if (DEBUG) {
-      (this.tag as any).didCompute(parentValue);
-    }
-
     let ret;
 
     if (EMBER_METAL_TRACKED_PROPERTIES) {
@@ -220,12 +184,7 @@ export class NestedPropertyReference extends PropertyReference {
     let parentReferenceTag = parentReference.tag;
     let propertyTag = (this.propertyTag = createUpdatableTag());
 
-    if (DEBUG) {
-      let tag = combine([parentReferenceTag, propertyTag]);
-      this.tag = TwoWayFlushDetectionTag.create(tag, propertyKey, this);
-    } else {
-      this.tag = combine([parentReferenceTag, propertyTag]);
-    }
+    this.tag = combine([parentReferenceTag, propertyTag]);
   }
 
   compute(): Opaque {
@@ -245,10 +204,6 @@ export class NestedPropertyReference extends PropertyReference {
         watchKey(parentValue, propertyKey);
       }
 
-      if (DEBUG) {
-        (this.tag as any).didCompute(parentValue);
-      }
-
       let ret;
 
       if (EMBER_METAL_TRACKED_PROPERTIES) {

packages/@ember/-internals/metal/index.ts

@@ -60,7 +60,6 @@ export { addObserver, activateObserver, removeObserver, flushAsyncObservers } fr
 export { Mixin, aliasMethod, mixin, observer, applyMixin } from './lib/mixin';
 export { default as inject, DEBUG_INJECTION_FUNCTIONS } from './lib/injected_property';
 export { tagForProperty, tagFor, markObjectAsDirty, UNKNOWN_PROPERTY_TAG } from './lib/tags';
-export { default as runInTransaction, didRender, assertNotRendered } from './lib/transaction';
 export {
   consume,
   Tracker,

packages/@ember/-internals/metal/lib/property_events.ts

@@ -1,14 +1,12 @@
 import { Meta, peekMeta } from '@ember/-internals/meta';
 import { symbol } from '@ember/-internals/utils';
 import { EMBER_METAL_TRACKED_PROPERTIES } from '@ember/canary-features';
-import { DEBUG } from '@glimmer/env';
 import changeEvent from './change_event';
 import { descriptorForProperty } from './descriptor_map';
 import { sendEvent } from './events';
 import { flushSyncObservers } from './observer';
 import ObserverSet from './observer_set';
 import { markObjectAsDirty } from './tags';
-import { assertNotRendered } from './transaction';
 
 /**
  @module ember
@@ -69,10 +67,6 @@ function notifyPropertyChange(obj: object, keyName: string, _meta?: Meta | null)
   if (PROPERTY_DID_CHANGE in obj) {
     obj[PROPERTY_DID_CHANGE](keyName);
   }
-
-  if (DEBUG) {
-    assertNotRendered(obj, keyName);
-  }
 }
 
 const SEEN_MAP = new Map<object, Set<string>>();

packages/@ember/-internals/metal/lib/tracked.ts

@@ -59,6 +59,7 @@ if (DEBUG) {
     // this when the value is minified.
     if (
       name.match(/<.*:ember\d+>/) &&
+      className &&
       !className.startsWith('_') &&
       className.length > 2 &&
       className !== 'Class'