From 67d116ebf7f1501a87780a6e7aa397fadf98ee48 Mon Sep 17 00:00:00 2001 From: Josemar Luedke Date: Sun, 16 Oct 2016 12:36:04 -0700 Subject: [PATCH] Deprecate renderToElement --- .../tests/integration/components/append-test.js | 2 ++ packages/ember-views/lib/mixins/view_support.js | 11 +++++++++++ 2 files changed, 13 insertions(+) diff --git a/packages/ember-glimmer/tests/integration/components/append-test.js b/packages/ember-glimmer/tests/integration/components/append-test.js index 2bcd30e3711..fb004ff1250 100644 --- a/packages/ember-glimmer/tests/integration/components/append-test.js +++ b/packages/ember-glimmer/tests/integration/components/append-test.js @@ -635,6 +635,7 @@ moduleFor('appendTo: with multiple components', class extends AbstractAppendTest moduleFor('renderToElement: no arguments (defaults to a body context)', class extends AbstractAppendTest { append(component) { + expectDeprecation(/Using the `renderToElement` is deprecated in favor of `appendTo`. Called in/); let wrapper; this.runTask(() => wrapper = component.renderToElement()); @@ -652,6 +653,7 @@ moduleFor('renderToElement: no arguments (defaults to a body context)', class ex moduleFor('renderToElement: a div', class extends AbstractAppendTest { append(component) { + expectDeprecation(/Using the `renderToElement` is deprecated in favor of `appendTo`. Called in/); let wrapper; this.runTask(() => wrapper = component.renderToElement('div')); diff --git a/packages/ember-views/lib/mixins/view_support.js b/packages/ember-views/lib/mixins/view_support.js index 80665abee40..1d82a3a9845 100644 --- a/packages/ember-views/lib/mixins/view_support.js +++ b/packages/ember-views/lib/mixins/view_support.js @@ -215,11 +215,22 @@ export default Mixin.create({ @method renderToElement @param {String} tagName The tag of the element to create and render into. Defaults to "body". @return {HTMLBodyElement} element + @deprecated Use appendTo instead. @private */ renderToElement(tagName) { tagName = tagName || 'body'; + deprecate( + `Using the \`renderToElement\` is deprecated in favor of \`appendTo\`. Called in ${this.toString()}`, + false, + { + id: 'ember-views.render-to-element', + until: '2.12.0', + url: 'http://emberjs.com/deprecations/v2.x#toc_code-rendertoelement-code' + } + ); + let element = this.renderer.createElement(tagName); this.renderer.appendTo(this, element);