New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Ember.Test.waiters in wait helper #139

Closed

adamjmcgrath opened this issue Jan 15, 2016 · 3 comments

Contributor

adamjmcgrath commented Jan 15, 2016

Hypothetically - if I created a PR to add the Ember.Test.waiters check in:
https://github.com/emberjs/ember.js/blob/master/packages/ember-testing/lib/helpers.js#L197
To the wait helper:
https://github.com/switchfly/ember-test-helpers/blob/master/lib/ember-test-helpers/wait.js#L30
Might that be accepted - or is there a reason why it doesn't include that check?

The text was updated successfully, but these errors were encountered:

Member

rwjblue commented Jan 15, 2016

Seems like a good idea. I'm happy to help provide guidance if needed...

Contributor Author

adamjmcgrath commented Jan 15, 2016

Thanks - I'll prepare a PR

adamjmcgrath mentioned this issue

Add support for Ember Test registered waiters to wait helper #141

Merged

Contributor Author

adamjmcgrath commented Feb 3, 2016

Released in v0.5.21 - thanks

adamjmcgrath closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment