Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

did-insert not triggering re-render for tracked changes #20

Open
patricklx opened this issue Feb 18, 2020 · 4 comments
Open

did-insert not triggering re-render for tracked changes #20

patricklx opened this issue Feb 18, 2020 · 4 comments

Comments

@patricklx
Copy link
Contributor

e.g. in the example given in the code comments, the this.count is not updated in the template...

https://github.com/emberjs/ember-render-modifiers/blob/master/addon/modifiers/did-insert.js#L29

in the callstack i see that installModifier is called with a untrack context

probably because of this:
#16
?

@btecu
Copy link

btecu commented Feb 26, 2020

I believe did-insert is supposed to trigger when the element is inserted into the DOM.

@btecu
Copy link

btecu commented Feb 26, 2020

Perhaps you want did-update?

@patricklx
Copy link
Contributor Author

patricklx commented Feb 27, 2020

No, what i mean is that everything inside the did-insert callback is not in a tracking context. So, if a tracked property is updated in it, other parts tracking it will not know about the change

Copy link
Member

rwjblue commented Mar 29, 2020

Can you describe the actual issue you are running into? did-insert is only called once (upon insertion) so I'm a bit confused about what is actually biting you...

@patricklx patricklx changed the title did-insert not triggering tracked changes did-insert not triggering re-render for tracked changes Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants