-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifiers don't seem to work when applied to elements are ember components with tagName=''
#15
Comments
Apologies - I updated the name and content of the first comment - I misspoke on glimmer vs. ember. Issue is correct now. |
tagName=''
Further update - some more testing reveals that the issue only occurs when the target component has |
Confirm, when using |
As the issue unfolds here a little further, it's worth mentioning that the parent glimmer component (GC) needs to use the did-update modifier, not to alter the element, but to detect changes on an incoming attribute on the GC. Not the intended use of a modifier, but not sure GCs offer any other way to do so - thinking an EC task with Any thoughts? |
I'm doing some issue gardening 🌱🌿 🌷 and came upon this issue. Since it's quite old I just wanted to ask if this is still relevant? If it isn't, maybe we can close this issue! By closing some old issues we reduce the list of open issues to a more manageable set. |
This is covered by machty/emblem.js#340 but is still an issue - the fundamental point being that modifiers don't work "as one might intuitively expect at first glance" when used on components - if #340 is solved, I think this would cease to be a problem. |
Using modifiers on an element that is itself a classic Ember component (
@ember/component
) doesn't seem to work.This poses difficulties because the developer now has to 'know' what the
other component is.
This works great:
This not so much (doesn't error, doesn't execute).
The text was updated successfully, but these errors were encountered: