Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moduleFor could accept callback as second argument #45

Closed
ppcano opened this issue Apr 28, 2014 · 1 comment
Closed

moduleFor could accept callback as second argument #45

ppcano opened this issue Apr 28, 2014 · 1 comment

Comments

@ppcano
Copy link

ppcano commented Apr 28, 2014

This function argument contract are closed to the qunit module API.

In much of the cases, developers would write integration tests through qunit module and unit tests with ember-qunit module api, in that case, having the module method to support the same format could originate less errors.

The API could also accept:

moduleFor(fullName, callback, delegate)
moduleFor(fullName, delegate)
@dgeb
Copy link
Member

dgeb commented Nov 1, 2014

With the refactor to use ember-test-helpers, description can now be omitted - see https://github.com/switchfly/ember-test-helpers/blob/master/lib/ember-test-helpers/test-module.js#L7-12

@dgeb dgeb closed this as completed Nov 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants