From 58e85fcf8c0037526204c7e240d7ba4e4e7f2482 Mon Sep 17 00:00:00 2001 From: Robert Jackson Date: Tue, 9 Mar 2021 12:17:30 -0500 Subject: [PATCH] Relax peer dependency minimum versions to original ember-qunit@5.0.0 versions. ember-qunit@5.0.0 shipped with `qunit: ^2.13.0` and `@ember/test-helpers: ^2.1.0`. However, when Dependabot landed a dependency update for our internal dev dependencies it also increased the minimum for the peerDep (in https://github.com/emberjs/ember-qunit/commit/719af61effe22013b9d9768d8af9eff9243e27e2 and https://github.com/emberjs/ember-qunit/commit/fd9fa19ac09a7ad3a3bd88ef2b7b5faa9c9b747c) both of which were released in ember-qunit@5.1.2. Changing the minimum version of a peer dependency that we enforce (via `validatePeerDependencies`) should be considered a breaking change! This reverts that change and sets the peer dependencies back to its value when 5.0.0 was published. --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index f0356aff..2d38da7b 100644 --- a/package.json +++ b/package.json @@ -68,8 +68,8 @@ "release-it-lerna-changelog": "^3.1.0" }, "peerDependencies": { - "@ember/test-helpers": "^2.2.3", - "qunit": "^2.14.0" + "@ember/test-helpers": "^2.1.0", + "qunit": "^2.13.0" }, "engines": { "node": "10.* || 12.* || >= 14.*"