4.13 Canary | Regression Tracking #9639
Comments
|
Trying out 4.13-alpha.4 (upgraded from latest 4.12) I ran into what appears to be an inflection issue. Did anything change in that area, or am I missing something else? Model definition with It's set up with the inflector as: |
|
@nickschot great find! in 5.x we deprecated support for ember-inflector. 5.x deprecations are activateable in 4.13 but off-by-design since they would be new deprecations. To manage that deprecation, we automatically intercept inflections from ember-inflector and add them to our own inflection library. That interception logic in Sidenote: the check |
|
Some quick answers to that & a bit more context:
EDIT:
|
|
Thanks! I'll get that initializer backported :) |
|
@nickschot Can you try the latest 4.13 canary? It should have the initializer fix. |
Most of our test suite seems to pass on CI, but the initializer fix doesn't seem to work when running tests through I also had to make sure to have all the proper @ember-data & @warp-drive packages available in the top level node_modules (did a quick fix with a public hoist for testing). There's also some other issues, but I have to dig into those more to see if that's just caused by the test setup. |
via any mechanism or just when launching that way?
because typescript? or because you build with embroider which disallows the transitive dependency and thus things like |
As discussed in chat: breaks on visiting In addition
|
|
I just updated from 4.13.0-alpha.4 to 4.13.0-alpha.5, and now I’m getting an error related to Webpack and ember-auto-import. If I remove the @warp-drive/build-config is hoisted. |
|
@LuisMacedoKantar is there a log of what the error is anywhere? |
|
Yes @runspired
|
|
@runspired, I just updated to the new version 4.13.0-alpha.6 and also the new warpdrive/build-config 0.0.2, and everything seems to be working now with the setConfig. |
|
|
|
I had some inflector rules in an initializer: import Inflector from 'ember-inflector';
export function initialize(/* application */) {
const inflector = Inflector.inflector;
inflector.uncountable('price-quote-extra-services');
}
export default {
name: 'custom-inflector-rules',
initialize,
};But this threw errors in my test app where I defined that model:
I ended up just throwing away ember-inflector and used @ember-data/request-utils/string, which was fine for me, but still, a regression. |
|
@BoussonKarel see item: that said I think if you are on latest 4.13 this has now been done, though @nickschot mentioned it seems the initializer fix only works in the app, not in tests ... which is pretty odd. |
Yeah seemed like a potential ordering issue. Not entirely clear. Setting up the inflections in app.js works fine for all scenarios as far as i could see. edit: I've only tried that with ember-inflector v5+ (so v2 addon version). |
I am on the latest version (4.13.0-alpha.6). The inflections were defined in an initializer and the models were added in a test. |
WONTFIX
ember-datapackage@ember-data/storeinstead ofember-data/storenow requires full configuration@ember-data/storeno longer worksmodel._notifyPropertieshas been removedYou must include an 'id' for the resource data ${resource.type}Missing Resource Type: received resource data with a type '${resource.type}' but no schema could be found with that name.belongsToReference.belongsToRelationshipandhasManyReference.hasManyRelationshiphave been removed.MAYBEFIX
adapter.useFetchis assigned in a new way, resulting in the getter approach in app adapters not working. fields approach works e.g.useFetch = false.isRelationshipandisAttributeon field meta is no longer present. These were meant to be private and not part of the spec, but some apps may have discovered and made use of them.keyon field meta is no longer present, this was a private reflection ofnameandnameshould be used instead.createRecordin a test expecting a re-render, you need toawait settledTO FIX
registerSchemadoes not setup schema in a way that avoids the store attempting to callcreateSchemaServicegetSchemaDefinitionServiceonly checks for schemas registered withregisterSchemaThe `request` passed to `RequestManager.request(<request>)` was empty (`{}`). Requests need at least one valid key.FIXED
The text was updated successfully, but these errors were encountered: