Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ds-references stripped from production? #4216

Closed
richmolj opened this issue Mar 7, 2016 · 4 comments
Closed

ds-references stripped from production? #4216

richmolj opened this issue Mar 7, 2016 · 4 comments

Comments

@richmolj
Copy link

richmolj commented Mar 7, 2016

I'm using the new ds-references feature flag from ember-data 2.4. Everything works in development, but in production it looks like the code is not being applied:

From console:

> EmberENV.FEATURES
>> Object {ds-references: true}
> model._internalModel.referenceFor
>> undefined
@bmac
Copy link
Member

bmac commented Mar 7, 2016

Feature flags that are not turned on by default (like ds-references) are only suppose to be accessible on the canary branch. I believe the fact that ds-references is available in development is a bug.

@richmolj
Copy link
Author

richmolj commented Mar 7, 2016

There is a warning about this when I run 2.4 in development.

@kernel-io
Copy link

provided that this is still behind a feature flag, is there any safe way to get only the id of the relationship with 2.4?

@pangratz
Copy link
Member

As @bmac pointed out, ds-references is not yet available in a release of ember-data. Currently it's available in canary and 2.5-beta series. It will most likely be included when 2.5 is released.


There is a warning about this when I run 2.4 in development.

@richmolj this has been fixed upstream in Ember.js, see #4213 for reference.


provided that this is still behind a feature flag, is there any safe way to get only the id of the relationship with 2.4?

@kernel-io unfortunately there is no way, other than using private API.


I am going to close this issue as the original issue should be clarified now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants