Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make async relationships default #3220

Closed
igorT opened this issue Jun 6, 2015 · 5 comments
Closed

Make async relationships default #3220

igorT opened this issue Jun 6, 2015 · 5 comments

Comments

@igorT
Copy link
Member

igorT commented Jun 6, 2015

In current ember data throw a deprecation on any relationship that is not async:false. Write an Ember Watson helper to add {async:false} to each one

@igorT
Copy link
Member Author

igorT commented Jun 11, 2015

@tomdale @wycats we are keeping the sync relationships, but changing the defaults
It's a two step process, 1.0final, no options throws deprecation unless you add async:false, but in 2.0 it's async by default unless you put sync:true

@abuiles
Copy link
Member

abuiles commented Jun 15, 2015

@Serabe
Copy link
Member

Serabe commented Jul 13, 2015

This is still open. Anything I can help with?

@sly7-7 sly7-7 closed this as completed Jul 14, 2015
@sly7-7 sly7-7 reopened this Jul 14, 2015
@sly7-7
Copy link
Contributor

sly7-7 commented Jul 14, 2015

Well, I thinks this could probably be closed, the Ember Watson exists, and #3488 has been merged.
@igorT c/d ?

@bmac
Copy link
Member

bmac commented Jul 25, 2015

I agree @sly7-7 this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants