Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with latest redux-observable v0.17.0 version #3

Open
SlyDen opened this issue Nov 8, 2017 · 3 comments
Open

Doesn't work with latest redux-observable v0.17.0 version #3

SlyDen opened this issue Nov 8, 2017 · 3 comments

Comments

@SlyDen
Copy link

SlyDen commented Nov 8, 2017

It looks like redux-observable module has index.js in different folder now lib/esm instead of lib/es. So it breaks here

const observablePath = path.dirname(require.resolve('redux-observable/lib/es/index.js'));
@toranb
Copy link
Contributor

toranb commented Nov 9, 2017

redux-observable/redux-observable#329

I've pinned the version of this shim to ~0.16 and released a v1.1.1 to solve that issue

Next I tried to bump this to v2.0 and add support for ~0.17 but I'm getting a fun error ;)

screen shot 2017-11-08 at 7 45 00 pm

^^ Anyone else see this if they hack the addon to boot ~0.17 ? I noticed it's very new so I may swing back to this in a week for good measure

@toranb
Copy link
Contributor

toranb commented Nov 9, 2017

screen shot 2017-11-08 at 7 47 51 pm

@SlyDen
Copy link
Author

SlyDen commented Nov 9, 2017

I cloned the shim's repo updated to 0.17.0 and tried to run the tests and got the same issue ... that's why instead of PR I made this ticket :) ... I thought I wasn't that familiar with redux-observable yet to find the problem just from the start and maybe you'll get the idea ...
I'm going to dig deeper the issue these days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants