isActive not taking context object into consideration

[balinterdi]

I have the following code where I wanted to replace link-to with ember-href-to and using the router service to calculate the active class:

{{#each model as |band|}}
  <a href={{href-to 'bands.band.songs' band.id}}
     class="list-group-item band-link {{if (is-active 'bands.band.songs' band.id) 'active'}}">
    {{band.name}}
    <span class="pointer glyphicon glyphicon-chevron-right"></span>
  </a>
{{/each}}

// app/helpers/is-active.js
import Ember from 'ember';

const { Helper, inject } = Ember;

export default Helper.extend({
  router: inject.service(),

  compute([value, ...models]) {
    return this.get('router').isActive(value, models);
  }
});

The problem I encountered is that all the links are active independently of the actual context object used. In other words, no matter which band link is transitioned to, is-active returns true for all of the links in the list:

I drilled down into the code to see what causes this and I've found that the router service polyfill calls the router's isActiveIntent method, which in turn calls NamedTransitionIntent.applyToHandlers (see here) to decide if the link generated is an active one.

However, NamedTransitionIntent.applyToHandlers clobbers the context by copying one context
over the other (see here), and will subsequently find that the handlers are equal and thus return true for isActiveIntent.

I also checked that link-to works fine for this scenario, very probably because it uses another code path to determine if a link is active.

The code I tested this with can be found on the router-service branch of balinterdi/rarwe-demo.

[NickChristensen]

Just ran into this same thing. In the meantime, is there even a hacky way to get a reference to the current model(s) for that route?

[balinterdi]

Not that I know of.

1. this.modelFor(routeName) only works for parent routes of the current route.
2. There might be a way to imitate what link-to does to see if a route is active (I assume that's why you want to get the current model for that route, too), but it seems to use a fair amount of private APIs (which is what the router service would solve).